[DataGrid] All selectors accept only apiRef as first argument
#16198
Conversation
|
Deploy preview: https://deploy-preview-16198--material-ui-x.netlify.app/ |
packages/x-data-grid-pro/src/components/GridDataSourceTreeDataGroupingCell.tsx
Outdated
Show resolved
Hide resolved
| const loadingSelector = (state: GridStatePremium) => state.dataSource.loading[id] ?? false; | ||
| const errorSelector = (state: GridStatePremium) => state.dataSource.errors[id]; | ||
| const loadingSelector = (apiRefObject: React.RefObject<GridApiPremium>) => | ||
| apiRefObject.current.state.dataSource.loading[id] ?? false; | ||
| const errorSelector = (apiRefObject: React.RefObject<GridApiPremium>) => | ||
| apiRefObject.current.state.dataSource.errors[id]; |
There was a problem hiding this comment.
These should probably be selectors with arguments.
There was a problem hiding this comment.
And rowSelector below as well.
| export const gridAggregationStateSelector = (state: GridStatePremium) => state.aggregation; | ||
| export const gridAggregationStateSelector = (apiRef: React.RefObject<GridApiPremium>) => | ||
| apiRef.current.state.aggregation; |
There was a problem hiding this comment.
I wonder if creating a createStateSelector that pre-fetches apiRef.current.state could be useful for readability.
There was a problem hiding this comment.
Creating a type like GridApiRef*** to make React.RefObject<GridApi***> more compact could also be nice.
There was a problem hiding this comment.
I was about to do that, but have to resolve rendering issues first 🙂
| const getPinnedColumns = React.useCallback<GridColumnPinningApi['getPinnedColumns']>(() => { | ||
| return gridPinnedColumnsSelector(apiRef.current.state); | ||
| return gridPinnedColumnsSelector(apiRef); | ||
| }, [apiRef]); |
There was a problem hiding this comment.
I wonder if we should deprecate API methods that only call a selector.
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Closes #11440